[SYCL] Add HIP arch argument for lit tests #4676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidanBeltonS
requested review from
bader,
pvchupin and
a team
as code owners
alexbatashev
suggested changes
Sep 30, 2021
|
Regardless of running the test on real hardware you must specify the amd-arch to compile anything when targetting |
alexbatashev
approved these changes
Sep 30, 2021
bader
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the HIP backend for an AMD platform the gpu's architecture must be sepcified with
-Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=<target>. This patch adds an option tobuildbot/configure.pywhich allows the user to state the gpu architecture for lit tests when runningcheck-sycl-hip.Relevant messages and docs are updated within the patch.
Edit:
This patch is needed even if the tests do not run on hardware, as the amd architecture must be specified for compilation.