[SYCL][ESIMD] Fix logic and arithmetic operators for simd_view with scalar #4680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calar These operators should call corresponding operator for simd_obj_imp with scalar instead of constructing simd object from input scalar themselves. simd_obj_impl operators will do the necessary type promotion for operands if needed which is not done in the current implementation.
kychendev
reviewed
Oct 3, 2021
kychendev
reviewed
Oct 3, 2021
kbobrovs
approved these changes
Oct 4, 2021
kychendev
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These operators should call corresponding operator for simd_obj_imp with
scalar instead of constructing simd object from input scalar themselves.
simd_obj_impl operators will do the necessary type promotion for operands
if needed which is not done in the current implementation.