[SYCL] Fix calculation of unreleased events in a pool #4730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change number of unreleased events was set to the maximum at event pool creation and then only decremented at the moment when event from the pool is released. This is not correct for the case when pool is not completely full. Patch fixes calculation of unreleased events in a pool. Signed-off-by: Artur Gainullin <[email protected]>
|
image_max_size.cpp fail is unrelated to the change. Fail happens on opencl backend which is not touched by this PR. Reported to the author of the test. |
|
Looks good. |
rdeodhar
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change number of unreleased events was set to the maximum at
event pool creation and then only decremented at the moment when event
from the pool is released. This is not correct for the case when pool
is not completely full.
Patch fixes calculation of unreleased events in a pool.
Signed-off-by: Artur Gainullin [email protected]