[ESIMD][LIT] Add trivial test cases for EsimdFenceMask enum #4757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
kbobrovs
reviewed
Oct 13, 2021
sycl/test/esimd/intrins_trans.cpp
Outdated
| @@ -152,6 +152,39 @@ SYCL_ESIMD_FUNCTION SYCL_EXTERNAL simd<float, 16> foo() { | |||
| // CHECK: %[[SI6:[0-9a-zA-Z_.]+]] = load i32, i32 addrspace(4)* %[[SI6_ADDR]] | |||
| // CHECK: call void @llvm.genx.scatter.scaled.v8i1.v8i32.v8i32(<8 x i1> %{{[0-9a-zA-Z_.]+}}, i32 0, i16 0, i32 %[[SI6]], i32 %{{[0-9a-zA-Z_.]+}}, <8 x i32> %{{[0-9a-zA-Z_.]+}}, <8 x i32> %{{[0-9a-zA-Z_.]+}}) | |||
| } | |||
| esimd_fence(ESIMD_GLOBAL_COHERENT_FENCE); | |||
There was a problem hiding this comment.
I would suggest to follow this procedure:
// 2. Test cases above should be refactored not to use user-level APIs like
// gather and use __esimd* calls instead.
since we are testing low-level intrinsic translation here, tests should better invoke __esimd_fence.
There was a problem hiding this comment.
Thank you. Fixed in 0c2f3fe
…ce() Signed-off-by: Vyacheslav N Klochkov <[email protected]>
|
The test esimd/matrix_transpose_usm.cpp failed on Windows/CI. It is unrelated to this PR. I made minor changes in the test matrix_transpose_usm.cpp to slightly reduce the chance of timeout: intel/llvm-test-suite#513 |
kbobrovs
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vyacheslav N Klochkov [email protected]