[SYCL] Improve diagnostics for invalid kernel names #4769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
smanna12
changed the title
Signed-off-by: Soumi Manna <[email protected]>
smanna12
changed the title
smanna12
requested review from
elizabethandrews and
premanandrao
as code owners
Fznamznon
reviewed
Oct 18, 2021
erichkeane
reviewed
Oct 18, 2021
Fznamznon
reviewed
Oct 27, 2021
Fznamznon
previously approved these changes
Oct 27, 2021
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
elizabethandrews
approved these changes
Oct 27, 2021
|
Thanks for the reviews everyone. |
premanandrao
approved these changes
Oct 27, 2021
erichkeane
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of lambda (which is not forward-declarable) in a SYCL kernel name currently generates the error message:
error: unnamed lambda ‘(lambda at {{.*}}filename.cpp{{.}’ used
The diagnostic message is very confusing and doesn't help to understand what exactly is wrong.
To update the message to make it better and more helpful, this patch modifies the error diagnostic when the lambdas (anonymous function object types) are used in SYCL kernel names.
Signed-off-by: Soumi Manna [email protected]