[ESIMD] Fix slm_gather/scatter. #4771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove limitations on element size being 4 bytes only - enable 1,8,16,32 elements as allowed by hardware - share implementation with surface-based gather/scatter Signed-off-by: Konstantin S Bobrovsky <[email protected]>
kbobrovs
requested review from
kychendev,
sndmitriev and
v-klochkov
as code owners
kbobrovs
force-pushed
the
fix_slm_gather_scatter
branch
from
729582b to
04dc860
Compare
kbobrovs
changed the title
v-klochkov
reviewed
Oct 18, 2021
sycl/include/sycl/ext/intel/experimental/esimd/detail/memory_intrin.hpp
Outdated
Show resolved
Hide resolved
v-klochkov
previously approved these changes
Oct 18, 2021
| /// \ingroup sycl_esimd | ||
| template <typename T, int N, typename AccessorTy, | ||
| CacheHint L1H = CacheHint::None, CacheHint L3H = CacheHint::None> | ||
| ESIMD_INLINE ESIMD_NODEBUG typename sycl::detail::enable_if_t< |
There was a problem hiding this comment.
Suggested change
| ESIMD_INLINE ESIMD_NODEBUG typename sycl::detail::enable_if_t< | |
| ESIMD_INLINE ESIMD_NODEBUG std::enable_if_t< |
|
The Jenkins failure is a failure of the single test: and expects |
v-klochkov
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__esimd_gather_masked_scaled2intrinsic which is the best choice to mapgatherto according to the VC BE teamComplementary new E2E tests and test fixes: intel/llvm-test-suite#517
Signed-off-by: Konstantin S Bobrovsky [email protected]