[SYCL] Fix build in clean environment #4782
Conversation
Fix issues discovered in intel#4773
| @@ -15,6 +15,8 @@ option(XPTI_ENABLE_TBB "Enable TBB in the framework" OFF) | |||
|
|
|||
| option(XPTI_ENABLE_WERROR OFF) | |||
|
|
|||
| option(XPTI_BUILD_SAMPLES OFF) | |||
There was a problem hiding this comment.
I see that samples build failed due to -Werror option. Shouldn't we just disable it or there other issues as well?
There was a problem hiding this comment.
I'd like -Werror to still be enabled. It sometimes catches bugs. that would've go under radar otherwise. But samples are not installed or tested, so I just excluded them from general builds.
There was a problem hiding this comment.
I'd like
-Werrorto still be enabled. It sometimes catches bugs. that would've go under radar otherwise. But samples are not installed or tested, so I just excluded them from general builds.
I'm suggesting disabling this option only for samples producing warnings. Excluding them from build can lead to the broken build.
Anyway I don't think XPTI samples are critical, so I'm okay to leave this solution if disabling -Werror for these samples is not easy to implement.
There was a problem hiding this comment.
Anyway I don't think XPTI samples are critical, so I'm okay to leave this solution if disabling -Werror for these samples is not easy to implement.
My intention is to eventually fix warnings properly and enable this option back under --ci-defaults, so that it is built regularly. But for now I just want to unblock my work on #4773
I don't see any failures. Was it some sort of infra problem? |
https://github.com/intel/llvm/pull/4773/checks?check_run_id=3925870915 |
|
@andykaylor friendly ping |
Fix issues discovered in #4773