[SYCL] Remove duplicate devices on submission to kernel_bundle API functions #4790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pec states that the compilation is for each unique device, duplicate devices removed. Here we ensure that the devices sent to the backend are each unique. Also, LevelZero doesn't support compilation for more than one device but it calls die() presently. Changing that as wel. Testss coming shortly. Signed-off-by: Chris Perkins <[email protected]>
…o filter out duplicate devices Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
changed the title
cperkinsintel
requested review from
againull,
smaslov-intel and
a team
as code owners
s-kanaev
reviewed
Oct 21, 2021
bader
changed the title
againull
reviewed
Oct 21, 2021
| if (NumDevices != 1) | ||
| die("piProgramCreateWithBinary: level_zero supports only one device."); | ||
| if (NumDevices != 1) { | ||
| zePrint("piProgramCreateWithBinary: level_zero supports only one device."); |
There was a problem hiding this comment.
Could you please clarify why it is not ok to use "die" here.
There was a problem hiding this comment.
It's mostly a matter of getting the devices to behave similarly. Right now, only the OpenCL GPU device supports compilation for multiple unique devices. All the other non-supporting devices throw exceptions when asked ... except LevelZero which dies.
|
@s-kanaev |
…d of device and b) use the private function dev.getNative() to ensure that device comparisons are unique Signed-off-by: Chris Perkins <[email protected]>
|
ping to reviewers. |
againull
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting devices to ::compile(), ::link(), ::build() and get_kernel_bundle(), section 4.11.7 of the SYCL 2020 spec states that the compilation is for each unique device, duplicate devices removed. Here we ensure that the devices sent to the backend are each unique. Also, LevelZero doesn't support compilation for more than one device but it calls
die()presently. Changing that as well. Tests at intel/llvm-test-suite#527Here the test PR is run against this PR (successfully): http://icl-jenkins.sc.intel.com:8080/job/SYCL_CI/job/intel/job/Lin/job/LLVM_Test_Suite/7703/
Signed-off-by: Chris Perkins [email protected]