[sycl-post-link][NFC] Another portion of small refactorings #4807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed unused variable and unnecessary members of ImagePropSaveInfo struct * Several logical parts of functions are moved in a separate functions * Several variable definitions moved closer to their use * Aliasing is used to reduce variable names Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
bader
reviewed
Oct 26, 2021
| if (HasIndirectlyCalledAssert) | ||
| continue; | ||
|
|
||
| HasAssertStatus HasAssert = hasAssertInFunctionCallGraph(&F); |
There was a problem hiding this comment.
Looking at implementation of this method I think this is very inefficient approach to find kernels calling __devicelib_assert_fail. IMHO, bottom-up approach is way more efficient. I.e. start with __devicelib_assert_fail function declaration and travers users gathering kernels.
Current implementation goes over all functions in the module even if __devicelib_assert_fail not declared!
Please, consider refactoring this code to improve performance.
There was a problem hiding this comment.
Fully agree with the suggestion, @mlychkov, could you please create a tracker for that?
There was a problem hiding this comment.
Yes, I'll create it.
Signed-off-by: Mikhail Lychkov <[email protected]>
AlexeySachkov
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Lychkov [email protected]