[SYCL] Set preprocessor macros in integration header #4823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Predefines which need to be set for custom host compilation must be defined in integration header. Signed-off-by: Elizabeth Andrews <[email protected]>
elizabethandrews
requested review from
premanandrao and
smanna12
as code owners
Signed-off-by: Elizabeth Andrews <[email protected]>
smanna12
reviewed
Oct 26, 2021
mdtoguchi
reviewed
Oct 26, 2021
Signed-off-by: Elizabeth Andrews <[email protected]>
Signed-off-by: Elizabeth Andrews <[email protected]>
smanna12
reviewed
Nov 4, 2021
Signed-off-by: Elizabeth Andrews <[email protected]>
smanna12
previously approved these changes
Nov 4, 2021
|
@elizabethandrews, can you please address failures in buildbot/sycl-win-x64-pr? |
ping. |
Taking a look now. I'm not sure why adding a few defines in integration header affects compilation of headers. I've updated the workspace to see if that fixes it. If not, I guess I will have to build a windows workspace and test |
bader
requested changes
Jan 12, 2022
error when using custom host compiler 'cl' Signed-off-by: Elizabeth Andrews <[email protected]>
elizabethandrews
dismissed stale reviews from premanandrao and smanna12
via
50f56d6
steffenlarsen
previously approved these changes
Jan 19, 2022
smanna12
previously approved these changes
Jan 19, 2022
bader
previously approved these changes
Jan 19, 2022
Signed-off-by: Elizabeth Andrews <[email protected]>
elizabethandrews
dismissed stale reviews from bader, smanna12, and steffenlarsen
via
036ef0a
smanna12
approved these changes
Jan 19, 2022
steffenlarsen
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Predefines which need to be set for custom host compilation
must be defined in integration header.
Signed-off-by: Elizabeth Andrews [email protected]