[SYCL] Disable std::byte code by _HAS_STD_BYTE #4834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MS VS allows to disable std::byte type using __HAS_STD_BYTE=0 (https://devblogs.microsoft.com/cppblog/c17-features-and-stl-fixes-in-vs-2017-15-3/). This patch disables SYCL code which relies on this type in this case.
romanovvlad
previously approved these changes
Oct 28, 2021
romanovvlad
previously approved these changes
Oct 28, 2021
bader
reviewed
Oct 28, 2021
bader
reviewed
Oct 29, 2021
| // RUN: %clangxx -fsycl -fsyntax-only -Xclang -verify -D_HAS_STD_BYTE=0 %s -Xclang -verify-ignore-unexpected=note,warning | ||
| // RUN: %clangxx -fsycl -fsyntax-only -Xclang -verify %s -Xclang -verify-ignore-unexpected=note,warning | ||
| // expected-no-diagnostics | ||
| #include <CL/sycl.hpp> |
There was a problem hiding this comment.
Sorry, I missed that the first time. I guess the problem is exposed on Windows platform only. Am I right?
Suggested change
| #include <CL/sycl.hpp> | |
| // REQUIRES: windows | |
| #include <CL/sycl.hpp> |
There was a problem hiding this comment.
Yes. But running both on Linux and Windows ensures that Linux is not regressed.
There was a problem hiding this comment.
It's not blocking, but this test is useless on Linux. It does nothing useful.
You might invent infinite number of other defines to tests if they are not regressed as well. What might be useful to dump all defines enabled by including sycl.hpp and check there is nothing unexpected.
bader
approved these changes
Oct 29, 2021
romanovvlad
approved these changes
Nov 1, 2021
|
@againull Could you please review? |
romanovvlad
changed the title
againull
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MS VS allows to disable std::byte type using _HAS_STD_BYTE=0
(https://devblogs.microsoft.com/cppblog/c17-features-and-stl-fixes-in-vs-2017-15-3/).
This patch disables SYCL code which relies on this type in this case.