Skip to content

Draft: [SYCL] Add noexcept to has_property #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

steffenlarsen
Copy link
Contributor

SYCL 2020 adds noexcept to has_property on SYCL objects that take property_list arguments. This changes adjust the existing implementation accordingly.

SYCL 2020 adds noexcept to has_property on SYCL objects that take
property_list arguments. This changes adjust the existing implementation
accordingly.

Signed-off-by: Steffen Larsen <[email protected]>
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting with C++17 noexcept is part of ABI. We should run additional testing to see the impact of this change before we can commit it.

@cperkinsintel
Copy link
Contributor

/summary:run

@steffenlarsen
Copy link
Contributor Author

Closing this until next ABI break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants