[SYCL] Use correct scalar types for vector elements on Windows #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
previously approved these changes
Aug 12, 2019
bader
reviewed
Aug 12, 2019
sndmitriev
force-pushed
the
public/sndmitriev/long-long-types
branch
from
25d0773 to
a1ed673
Compare
|
Removed -fsycl |
Implementation uses wrong types for 64-bit integers on Windows for vector elements because '[unsigned] long' is being used. But on Windows 'long' has 32 bits as opposed to 64 bits on Linux. This patch corrects this problem. Signed-off-by: Sergey Dmitriev <[email protected]>
sndmitriev
force-pushed
the
public/sndmitriev/long-long-types
branch
from
a1ed673 to
e933485
Compare
v-klochkov
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation uses wrong types for 64-bit integers on Windows for vector
elements because '[unsigned] long' is being used. But on Windows 'long'
has 32 bits as opposed to 64 bits on Linux. This patch corrects this
problem.
Signed-off-by: Sergey Dmitriev [email protected]