[SYCL][HIP] Check total local size before kernel launch #4929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmiller
added a commit
to npmiller/llvm-test-suite
that referenced
this pull request
Nov 10, 2021
This has been fixed in intel/llvm#4929
bader
approved these changes
Nov 16, 2021
smaslov-intel
approved these changes
Nov 16, 2021
againull
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jan 25, 2022
This has been fixed in intel/llvm#4929
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…est-suite#562) This has been fixed in intel#4929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the exact same check as in the CUDA plugin however it was missing from the HIP plugin apparently.
This fixes the llvm-test-suite test
DeprecatedFeatures/parallel_for_range.cppwith HIP.