[SYCL][CUDA] Add CoreOption flag to CUDA backend options #4930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidanBeltonS
requested review from
AGindinson,
hchilama and
mdtoguchi
as code owners
mdtoguchi
approved these changes
Nov 11, 2021
|
I think that these are the only options that the CUDA backend currently uses and they do not appear to be dependent other options. Further related CUDA options could be added, though I would not be sure of the use case if they are not used by SYCL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
cuda-gpu-arch,cuda-path,nocudalib, andfno-sycl-libspirvoptions to haveCoreOptionflag. The change allows the options to be used withclang-clfor Windows. Tests are modified and added to check that these options work withclang-cl. I believe this resolves issue #4764.