[SYCL][NFC] Fix static code analysis concerns #4932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via a static-analysis tool:
Pointer may be dereferenced after it was positively checked for NULL
Inside GenerateCode() function:
if (FD->isInlineBuiltinDeclaration() && Fn) {} ----> Pointer 'Fn' checked for NULL here
if (SyclOptReport.HasOptReportInfo(FD)) {
llvm::OptimizationRemarkEmitter ORE(Fn); ---> Pointer 'Fn' is dereferenced by passing argument 1 to function "OptimizationRemarkEmitter"
This patch checks Pointer 'Fn' inside routine to resolve the bug.
Signed-off-by: Soumi Manna [email protected]