[Driver][SYCL] Update default SPIR device arch to correlate with host #4936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default target arch for the device compilation when using -fsycl should match the target arch of the host compilation. x86_64 (64-bit) -> spir64 i686 (32-bit) -> spir Adjust locations where this is set (offload and device-only compiles) and modify the corresponding tests.
AGindinson
reviewed
Nov 12, 2021
Comment on lines
+1028
to
+1032
| if (HasValidSYCLRuntime) { | ||
| StringRef SYCLTargetArch = getDefaultSYCLArch(C); | ||
| if (SYCLfpga) | ||
| // Triple for -fintelfpga is spir64_fpga. | ||
| SYCLTargetArch = "spir64_fpga"; |
There was a problem hiding this comment.
Just to clarify: this does impact full compilation scenarios, right? In this case, does the E2E testing coverage that we have prove that E2E compilation/execution of DPC++ apps it's going to work on 32-bit systems? Or instead, could it be that it has never worked properly due to pointer size mismatch?
There was a problem hiding this comment.
In all honestly, I don't think we have done any testing on 32-bit systems. All of our configurations are 64-bit hosted and the use of spir64 is commonplace. The issue of the mismatch was only found due to the single internal 32-bit Windows build configuration (which isn't tested, it is just a build AFAIK)
AGindinson
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default target arch for the device compilation when using -fsycl
should match the target arch of the host compilation.
x86_64 (64-bit) -> spir64
i686 (32-bit) -> spir
Adjust locations where this is set (offload and device-only compiles)
and modify the corresponding tests.