[SYCL] Account for extern "C++" blocks in name validation #5014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When validating a name declared in scopes such as cl::sycl::kernel_handler, we were assuming that the top-level declaration context would be Decl::TranslationUnit. This is not the case when the header file is wrapped explicitly in extern "C++" blocks. Signed-off-by: Premanand M Rao <[email protected]>
premanandrao
requested review from
elizabethandrews and
smanna12
as code owners
smanna12
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating a name declared in scopes such as
cl::sycl::kernel_handler, we were assuming that the top-level
declaration context would be Decl::TranslationUnit. This is
not the case when the header file is wrapped explicitly in
extern "C++" blocks.
Signed-off-by: Premanand M Rao [email protected]