[SYCL][FPGA][NFC] Update [[intel::use_stall_enable_clusters]] attribute #5053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch refactors [[intel::use_stall_enable_clusters]] attribute:
1. Uses automatic diagnostic checking when passing the wrong
number of arguments (which is an error instead of a warning
and this behavior is more consistent with other attributes).
2. The attribute has no arguments, So this only returns
the attribute itself instead of
handleSimpleAttribute<SYCLIntelUseStallEnableClustersAttr>
3. Existing test (SemaSYCL/stall_enable_device.cpp) shows
the behavior of automatic diagnostic checking when passing
the wrong number of arguments
Example:
[[intel::use_stall_enable_clusters(1)]] void test1() {} // expected-error{{'use_stall_enable_clusters' attribute takes no arguments}}
Signed-off-by: Soumi Manna <[email protected]>
smanna12
requested review from
elizabethandrews and
premanandrao
as code owners
AaronBallman
approved these changes
Dec 1, 2021
smanna12
changed the title
|
@premanandrao / @elizabethandrews, could you please review? Thank you |
elizabethandrews
approved these changes
Dec 2, 2021
|
Thank you everyone for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors [[intel::use_stall_enable_clusters]] attribute:
Signed-off-by: Soumi Manna [email protected]