-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][CUDA][PI] Add CUDA-specific pi_mem_advice values #5090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition but we should be consistent with other implementations.
@steffenlarsen @smaslov-intel could we get another review on this one please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry for the delay.
/verify with intel/llvm-test-suite#602 |
/verify with intel/llvm-test-suite#602 |
[2022-02-04T14:18:47.318Z] Failed Tests (2): @t4c1, it looks like these tests should be updated as well. |
The tests are now updated. |
/verify with intel/llvm-test-suite#602 |
Add tests for CUDA-specific pi_mem_advice values are being added in intel/llvm#5090.
…llvm-test-suite#602) Add tests for CUDA-specific pi_mem_advice values are being added in intel#5090.
Add CUDA-specific pi_mem_advice values and implement support for them in PI.
Tests: intel/llvm-test-suite#602