Skip to content

[SYCL][CUDA][PI] Add CUDA-specific pi_mem_advice values #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 9, 2022

Conversation

t4c1
Copy link
Contributor

@t4c1 t4c1 commented Dec 6, 2021

Add CUDA-specific pi_mem_advice values and implement support for them in PI.

Tests: intel/llvm-test-suite#602

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition but we should be consistent with other implementations.

@AerialMantis
Copy link
Contributor

@steffenlarsen @smaslov-intel could we get another review on this one please.

steffenlarsen
steffenlarsen previously approved these changes Feb 1, 2022
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay.

@t4c1 t4c1 requested a review from a team as a code owner February 3, 2022 14:08
@t4c1 t4c1 requested a review from smaslov-intel February 3, 2022 14:09
@bader
Copy link
Contributor

bader commented Feb 3, 2022

/verify with intel/llvm-test-suite#602

@bader
Copy link
Contributor

bader commented Feb 4, 2022

/verify with intel/llvm-test-suite#602

@bader
Copy link
Contributor

bader commented Feb 6, 2022

[2022-02-04T14:18:47.318Z] Failed Tests (2):
[2022-02-04T14:18:47.318Z] SYCL :: DiscardEvents/discard_events_usm.cpp
[2022-02-04T14:18:47.318Z] SYCL :: DiscardEvents/discard_events_usm_ooo_queue.cpp

@t4c1, it looks like these tests should be updated as well.

@t4c1
Copy link
Contributor Author

t4c1 commented Feb 8, 2022

The tests are now updated.

@bader
Copy link
Contributor

bader commented Feb 8, 2022

/verify with intel/llvm-test-suite#602

@bader bader merged commit e2e71a9 into intel:sycl Feb 9, 2022
bader pushed a commit to intel/llvm-test-suite that referenced this pull request Feb 9, 2022
Add tests for CUDA-specific pi_mem_advice values are being added in intel/llvm#5090.
@t4c1 t4c1 deleted the cuda_memadvise branch March 15, 2022 08:51
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…llvm-test-suite#602)

Add tests for CUDA-specific pi_mem_advice values are being added in intel#5090.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants