[CI] Add LLVM test suite jobs to reusable workflow #5097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/sycl: [CI] Add container users to video group (intel#5101) [CI] More typo fixes in Nightly build (intel#5088) Revert "[CI] Disable pack and upload steps (intel#5119)" (intel#5125) [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122) [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109) [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928) [CI] Disable pack and upload steps (intel#5119) [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780) [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076) [SYCL] Fix typo in the name of the host-visible pool (intel#5073) [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983) [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095) [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107) [SYCL] Fix a few warnings during build scripts configuration (intel#5082) [SYCL] Fix amdgpu openmp test (intel#5103) [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066) [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099) Remove PR disable template (intel#5102) [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078)
* sycl: [CI] Refactor workflow files (intel#5134) [CI] Enable HIP and CUDA plugins in GitHub Actions builds (intel#5087) [SYCL] Implement queue flushing (intel#5052) [SYCL] Allow library mismatch for libdevice host object on Win32 (intel#5048) [SYCL] Remove unnecessary template parameter (intel#5127) [CI] Use clang-format from nightly builds (intel#5126)
alexbatashev
changed the title
bader
reviewed
Dec 18, 2021
Comment on lines
+194
to
+195
| - name: Pack LIT | ||
| run: tar -cJf lit.tar.xz -C $GITHUB_WORKSPACE/src/llvm/utils/lit . |
There was a problem hiding this comment.
LIT can be installed with pip - https://llvm.org/docs/TestSuiteGuide.html#quickstart.
Would it be more optimal to install it into docker images used for testing?
There was a problem hiding this comment.
From what I see, these are only released versions of lit. Although, it does not get updates that often, I'm still not sure if there's any kind of compatibility guarantees for tests and lit.
|
|
||
| llvm_test_suite_l0_gen9: | ||
| name: L0 GEN9 Test Suite | ||
| needs: [build, configure] |
There was a problem hiding this comment.
One caveat: I think build here means "build+lit", right?
I think it might be useful to let developers run llvm-test-suite even if some LIT tests fail.
There was a problem hiding this comment.
Good point, I'll think about it
It's disabled for two reasons.
|
bader
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes:
General idea: one build job compiles SYCL toolchain with all available backends enabled. Test jobs wait for build to complete and download pre-built artifact to run tests in parallel on various hardware. Amount of testing can be configured from outside by specifying
lts_configparameter with one or more of the following values, separated with semicolon:ocl_x64,ocl_gen9,l0_gen9,hip_amdgpu. When tests are done, results from all the jobs are uploaded to lit_results artifact, which will contain all the logs in JSON format. Also, GitHub will automatically send notification to PR owner if one of the jobs has failed.