[SYCL] Widen (u)int8/16 to (u)int32 and half to float in group_broadcast #5110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPU device does not yet support the (u)int8/16 and half versions.
|
/summary:run |
dnmokhov
requested review from
AlexeySachkov,
Pennycook and
a team
as code owners
Are there plans to revert this change when the CPU device adds support for these functions? |
- Add FIXMEs. - Bitcast half to int16_t (and then widen to int32_t) to keep the precision. - Refactor the widening code into a separate helper. - Add tests for all 3 group_broadcast overloads.
|
/summary:run |
There are. I have just added a couple of |
AlexeySachkov
approved these changes
Dec 13, 2021
vladimirlaz
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPU device does not yet support the (u)int8/16 and half versions.