[SYCL] Reduce cost of XPTI instrumentation #5158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -175,7 +180,7 @@ class plugin { | |||
| pi::emitFunctionEndTrace(CorrelationID, PIFnName); | |||
| pi::emitFunctionWithArgsEndTrace(CorrelationIDWithArgs, | |||
| static_cast<uint32_t>(PiApiOffset), | |||
| PIFnName, ArgsData.data(), R, *MPlugin); | |||
| PIFnName, ArgsDataPtr, R, *MPlugin); | |||
There was a problem hiding this comment.
Should you also put lines 180-181 under if (xptiTraceEnabled())?
There was a problem hiding this comment.
I don't think so. Bodies of those functions are wrapped with if (xptiTraceEnabled()) already. The main overhead here is from packing arguments.
There was a problem hiding this comment.
It just looks strange that the call to emitFunctionWithArgsBeginTrace is guarded above (I assume their bodies also have that check) but these are not. Anyways, I am fine as is if you don't want to change
There was a problem hiding this comment.
Right, I'm planning some more changes to shut down notifications, that are not received by any party. This is a temporary fix for the problem anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument pack added unwanted overhead. Guard it with
xptiTraceEnabled()with the intention to guard it with new API, that would allow instrumented apps to check if the stream is observed.