[SYCL][USM] Enable per-context USM behavior. Use PI interfaces and avoid directly calling CL inside SYCL RT. #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Brodman <[email protected]> Initial commit for rewriting USM to support PI and multiple contexts. Signed-off-by: James Brodman <[email protected]> Update CLUSM test. clext test no longer relevant. Signed-off-by: James Brodman <[email protected]>
…tictxt tests. Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
jbrodman
force-pushed
the
usmpimultictxt
branch
from
0220bc5 to
e545d17
Compare
romanovvlad
requested changes
Aug 20, 2019
sycl/test/usm/findplatforms.hpp
Outdated
| @@ -11,24 +11,23 @@ bool findPlatformAndDevice(cl_device_type deviceType, | |||
| cl_int errorCode; | |||
|
|
|||
| errorCode = clGetPlatformIDs(0, nullptr, &numPlatforms); | |||
| if (errorCode != CL_SUCCESS) return false; | |||
There was a problem hiding this comment.
Why are you removing check. Does it make sense to continue if this call fails?
There was a problem hiding this comment.
Error checking was causing problems. Those slipped out.
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
romanovvlad
requested changes
Aug 21, 2019
Signed-off-by: James Brodman <[email protected]>
romanovvlad
approved these changes
Aug 22, 2019
| void *ParamValue, size_t *ParamValueSizeRet); | ||
|
|
||
| private: | ||
| bool mEmulated = false; |
There was a problem hiding this comment.
Probably instead of having this var you can check if mEmulator is nullptr or not.
|
|
||
| void *hostMemAlloc(pi_context Context, cl_mem_properties_intel *Properties, | ||
| size_t Size, pi_uint32 Alignment, pi_result *ErrcodeRet); | ||
| void *deviceMemAlloc(pi_context Context, pi_device Device, |
There was a problem hiding this comment.
Are you going to move these functions to pi.hpp/pi.cpp ?
There was a problem hiding this comment.
No, I think it's better to keep them here as we need some state (the CLUSM object). In some sense the Dispatcher is separate piece of PI. It's easy to wire new backends up here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USM Impl now goes through a USMDispatcher class tied to a context. USMDispatcher provides the single location to map to low-level APIs.
Add tests for multi-context behavior. These tests only run if both a CPU and GPU are found.
Replaces #467