Skip to content

[LIBCLC] Add functionality for in-kernel asserts for CUDA backend #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Dec 17, 2021

Adding functionality for in-kernel asserts with CUDA backend.

Responding to #3385.

@hdelan hdelan requested a review from bader as a code owner December 17, 2021 18:51
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure if libclc is the right place for this function. AFAIK, OpenCL doesn't support __assertfail.

@hdelan
Copy link
Contributor Author

hdelan commented Dec 20, 2021

This is perhaps a temporary fix. A proper fix might result in changes to libdevice, or even libc. If you have specific ideas on how to best resolve this please let us know your thoughts. Thanks

@bader bader changed the title [LIBCLC] Adding functionality for in-kernel asserts for CUDA backend [LIBCLC] Add functionality for in-kernel asserts for CUDA backend Dec 20, 2021
@bader
Copy link
Contributor

bader commented Dec 20, 2021

I would like to get @s-kanaev's opinion on a proper fix.
As @s-kanaev is away, I'm okay to merge this one as a temporary solution.

@bader bader merged commit 5a87b8c into intel:sycl Dec 20, 2021
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Dec 23, 2021
* upstream/sycl: (1382 commits)
  [SYCL][XPTI] Report memory allocation info from SYCL runtime (intel#5172)
  [CI] Switch labels for OCL x64 job (intel#5185)
  [SYCL] Add basic support for the generic_space address space (intel#5148)
  [CI] Update CODEOWNERS for SYCL printf support passes (intel#5199)
  [SYCL][Matrix] Enable wi_slice for joint_matrix (intel#4979)
  [SYCL][Group algorithms] Move group sort extension to experimental (intel#5169)
  [SYCL] Fix kernel bundles don't really carry kernel IDs (intel#5121)
  [SYCL] Initial printf support for non-constant AS format strings (intel#5069)
  [SYCL][NFC] Fix static code analysis concerns (intel#5189)
  [SYCL][Doc] Fix typos to fix doc build (intel#5190)
  [Driver][SYCL] Turn on -fsycl-dead-args-optimization by default (intel#3004)
  [SYCL][L0][Plugin] Add support for batching copy commands (intel#5155)
  [CI] Add cache checkout script to docker containers (intel#5184)
  [SYCL][Doc] Add HIP backend to the filter selector (intel#5176)
  [Doc] Add documentation for Docker images (intel#4778)
  [LIBCLC] Add functionality for in-kernel asserts for CUDA backend (intel#5174)
  Force opt to use new pass manager in exponential-deferred-inlining test after a8c2ba1
  [SYCL] Add vec and marray support to known_identity type trait (intel#5163)
  Correctly resolve merge conflicts
  Update SPV_INTEL_hw_thread_queries to rev 2
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants