[SPIR-V] Translate complex nested vector expressions instead of lowering them #5183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vmaksimo, FYI. @alexbatashev fixed tests failing on AMD GPU here - intel/llvm-test-suite#642. |
AlexeySotkin
previously approved these changes
Dec 21, 2021
Allow translator to go deeper into complex nested instructions. Enabled a possibility to translate expressions in `extractelement` and binary operator instructions (e.g., `fadd`, `fmul`). Also this change removes lowering for constant expression vector as the alternative approach was introduced - to translate any complicated nested instruction instead of lowering. Original commit: KhronosGroup/SPIRV-LLVM-Translator@c3c3c68b
vmaksimo
force-pushed
the
translate_constexpr
branch
from
088a5b4 to
a4f6b81
Compare
AlexeySotkin
approved these changes
Dec 21, 2021
|
The patch is ready for review. This is a cherry-pick of KhronosGroup/SPIRV-LLVM-Translator#1335 AFAIK the failures in the CI pre-commit test are not related to this patch. |
Is it ready for review or merge? @AlexeySotkin, do you want @AlexeySachkov to approve it as well? |
I wrote "ready for review" because before that it was a draft PR. But yes, this patch looks good to me and I'd like to merge it. I think @AlexeySachkov was added automatically as a codeowner(probably we should fix it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow translator to go deeper into complex nested instructions.
Enabled a possibility to translate expressions in
extractelementand binaryoperator instructions (e.g.,
fadd,fmul).Also this change removes lowering for constant expression vector as the
alternative approach was introduced - to translate any complicated nested
instruction instead of lowering.
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@c3c3c68