[SYCL][L0] Make cache of command-lists in the context per-device #5197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey V Maslov <[email protected]>
jandres742
reviewed
Dec 22, 2021
Signed-off-by: Sergey V Maslov <[email protected]>
|
The only failure is unrelated (fails with "acc" target) to my "gpu" targeted change:
|
againull
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per L0 spec "The application must only use the command list for the device, or its sub-devices, which was provided during creation":
https://spec.oneapi.io/level-zero/latest/core/api.html?highlight=zecommandlistcreate#_CPPv419zeCommandListCreate19ze_context_handle_t18ze_device_handle_tPK22ze_command_list_desc_tP24ze_command_list_handle_t
Signed-off-by: Sergey V Maslov [email protected]