Skip to content

[SYCL] Fix --shared-libs builds for generic AS printf support #5200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2021

Conversation

AGindinson
Copy link
Contributor

Fixes post-commit failures for #5069.

Signed-off-by: Artem Gindinson [email protected]

Fixes post-commit failures for intel#5069.

Signed-off-by: Artem Gindinson <[email protected]>
@AGindinson
Copy link
Contributor Author

@intel/llvm-gatekeepers, would it be OK if this got merged ahead of ESIMD code-owner approval? This aims to fix https://github.com/intel/llvm/runs/4604129664?check_suite_focus=true. I've verified locally via a --shared-libs build.

@AGindinson
Copy link
Contributor Author

AGindinson commented Dec 23, 2021

Failures in Basic/get_backend.cpp and XPTI tests do not seem related. Should I file an issue for these?

@AlexeySachkov
Copy link
Contributor

Failures in Basic/get_backend.cpp and XPTI tests do not seem related. Should I file an issue for these?

Absolutely, if we don't have such already. Also, failing (even sporadically) tests should be disabled

@bader
Copy link
Contributor

bader commented Dec 23, 2021

Failures in Basic/get_backend.cpp and XPTI tests do not seem related. Should I file an issue for these?

You shouldn't ask, you should always do this. It's your pull request and you are responsible for passing pre-commit checks.

FYI: intel/llvm-test-suite#659 - fix for XPTI test.
intel/llvm-test-suite#660 - a workaround for Basic\get_backend.cpp test.

@bader
Copy link
Contributor

bader commented Dec 23, 2021

@kbobrovs, @kychendev, @sndmitriev, @v-klochkov, ping.

@bader
Copy link
Contributor

bader commented Dec 24, 2021

@kbobrovs, @kychendev, @sndmitriev, @v-klochkov, I'm merging this to fix post-commit validation.
If you have any concerns, please, leave them in the comments.

@bader bader merged commit 04c18f2 into intel:sycl Dec 24, 2021
@AGindinson AGindinson deleted the shared-libs branch December 24, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants