[SYCL]Relax kernel-metadata.cpp test to allow downstream metadata. #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test kernel-metadata.cpp check-line is too specific, so it prevents
adding metadata in a downstream. This patch just removes the '{' so
additional metadata works.
Signed-off-by: Erich Keane <[email protected]>
bader
approved these changes
Aug 16, 2019
vladimirlaz
pushed a commit
to vladimirlaz/llvm
that referenced
this pull request
May 25, 2020
This patch makes several improvements to enable correct setting for
ContractionOFF:
1) Plain `fadd' or `fsub' instruction trigger ContractionOFF to
avoid optimizations that may fold them to an FMA.
2) `contract' flag is recognized on `fadd' and `fsub', and it allows
to suppress (1).
3) Undefined (external) functions, function pointers and inline asm
calls force ContractionOFF flag.
4) Contraction information is now propagated up the call stack until
an entry point.
Signed-off-by: Andrew Savonichev <[email protected]>
vladimirlaz
pushed a commit
to vladimirlaz/llvm
that referenced
this pull request
Jun 1, 2020
)" Signed-off-by: Andrew Savonichev <[email protected]>
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Jun 9, 2020
Found*contractedFMulAdd became unused after commit e89518b ("Enable
strict rules to set ContractionOFF (intel#521)", 2020-05-20).
Add a missing override to suppress a -Winconsistent-missing-override
warning.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
…tel#521) * [SYCL] Rename cuda, hip, level_zero backends to conform SYCL 2020 According to SYCL spec, backend::cuda is renamed to backend::ext_oneapi_cuda, backend::hip is renamed to backend::ext_oneapi_hip, and backend::level_zero is renamed to backend::ext_oneapi_level_zero. The backend interop APIs is available through separate header files "sycl/ext/oneapi/backend/<backendname>.hpp". * [SYCL] Rename hip backend to conform SYCL 2020 Signed-off-by: Pavel Samolysov <[email protected]> * [SYCL] Remove outdated header sycl/ext/oneapi/backend/cuda.hpp Signed-off-by: Pavel Samolysov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test kernel-metadata.cpp check-line is too specific, so it prevents
adding metadata in a downstream. This patch just removes the '{' so
additional metadata works.
Signed-off-by: Erich Keane [email protected]