Skip to content

[SYCL][CUDA][MATRIX] Remove using namespace experimental from headers #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2021

Conversation

JackAKirk
Copy link
Contributor

@JackAKirk JackAKirk commented Dec 23, 2021

Removed using namespace experimental - replaced with fully qualified names.

cc @vladimirlaz @bader

This PR fixes #5213. I chose to use fully qualified names instead of moving local detail to sycl::ext::oneapi::experimental::matrix::detail, although this second option seems the most sensible to me: however I didn't move detail at the moment for consistency with the intel matrix extension namespace use (which also coincides with the standard practice of wider dpc++ as far as I can tell).

Please be aware that using namespace experimental; is also used on line 201 of matrix-aot-amx.hpp, which could lead to similar problems in the future.

Signed-off-by: jack.kirk [email protected]

replaced with fully qualified names.

Signed-off-by: jack.kirk <[email protected]>
@JackAKirk JackAKirk requested a review from a team as a code owner December 23, 2021 20:09
@JackAKirk JackAKirk changed the title [SYCL][CUDA][MATRIX] removed namespace experimental - [SYCL][CUDA][MATRIX] removed using namespace experimental - Dec 23, 2021
@andreyfe1
Copy link
Contributor

Please be aware that using namespace experimental; is also used on line 201 of matrix-aot-amx.hpp, which could lead to similar problems in the future.

Would it be easier to fix the issue for matrix-aot-amx.hpp at this PR as well since the issue is the same? As I checked for whole repo only matrix-aot-amx.hpp and matrix-tensorcore.hpp have using namespace experimental

@bader bader changed the title [SYCL][CUDA][MATRIX] removed using namespace experimental - [SYCL][CUDA][MATRIX] Remove using namespace experimental from headers Dec 24, 2021
@bader
Copy link
Contributor

bader commented Dec 24, 2021

@JackAKirk, please, open a PR in llvm-test-suite repository enabling Matrix/joint_matrix_tensorcore_double.cpp on CUDA.

@bader
Copy link
Contributor

bader commented Dec 24, 2021

Please be aware that using namespace experimental; is also used on line 201 of matrix-aot-amx.hpp, which could lead to similar problems in the future.

@yubingex007-a11y, FYI.

@yubingex007-a11y
Copy link
Contributor

Please be aware that using namespace experimental; is also used on line 201 of matrix-aot-amx.hpp, which could lead to similar problems in the future.

@yubingex007-a11y, FYI.

Sure I will create a PR to handle that. Sorry for inconvenience.

@JackAKirk
Copy link
Contributor Author

@JackAKirk, please, open a PR in llvm-test-suite repository enabling Matrix/joint_matrix_tensorcore_double.cpp on CUDA.

Here it is, intel/llvm-test-suite#680, thanks.

@bader
Copy link
Contributor

bader commented Dec 25, 2021

/verify with intel/llvm-test-suite#680

@bader bader merged commit ec97c57 into intel:sycl Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mix of namespaces in headers causes build failures
5 participants