[NFC][SYCL] Make clang-format tolerate more LIT checks

[MrSidims]

Signed-off-by: Dmitry Sidorov [email protected]

[bader]

@MrSidims, @romanovvlad, the description of the PR added this exception promises something more than what we have implemented.

But disable the limit for comments containing specific keywords:
RUN, FAIL, REQUIRES, UNSUPPORTED, CHECK, expected-*

Do we want to fix the implementation to match the description?

[MrSidims]

@MrSidims, @romanovvlad, the description of the PR added this exception promises something more than what we have implemented.

But disable the limit for comments containing specific keywords:
RUN, FAIL, REQUIRES, UNSUPPORTED, CHECK, expected-*

Do we want to fix the implementation to match the description?

I do believe, that the intention was to enable clang-format for C++ code in the tests. I'm not sure why we would like to follow clang-format for check/run strings and LLVM IR itself.

[bader]

@MrSidims, @romanovvlad, the description of the PR added this exception promises something more than what we have implemented.

But disable the limit for comments containing specific keywords:
RUN, FAIL, REQUIRES, UNSUPPORTED, CHECK, expected-*

Do we want to fix the implementation to match the description?

I do believe, that the intention was to enable clang-format for C++ code in the tests. I'm not sure why we would like to follow clang-format for check/run strings and LLVM IR itself.

I think you are missing my point.
According to the description, the line limit should already be disabled for such comments.
But implementation doesn't match the description: if I read regular expression correctly, it disables the limit for the lines where specific keywords are followed by the space (e.g. word must end with it and not just contain) + there must be a colon after the keyword.

Another problem with this whole approach is that tests must use only standard FileCheck keywords and I don't see this rule to be harden by CI or some other way.

[bader]

if I read regular expression correctly, it disables the limit for the lines where specific keywords are followed by the space (e.g. word must end with it and not just contain) + there must be a colon after the keyword.

"(RUN|FAIL|REQUIRES|UNSUPPORTED|CHECK) *:"

I think this matches a keyword followed by a colon with 0 or more spaces between them. Right?
Anyway, this doesn't match the description of the PR and we probably should fix this mismatch instead.

[MrSidims]

@bader please check out the newest approach, hope I did get you correctly.
I've also noted, that sub_buffer.cpp (fresh test) failed in pre-commit, investigating.

[bader]

I suggest you test this change with 4bc20ab.

[MrSidims]

@bader clang-format there has passed: https://github.com/intel/llvm/runs/4651131820?check_suite_focus=true

[bader]

Good.

[bader]

Good enough for me. It's not perfect, but I don't think it's worth improving it before we see the need for this.
I'd like original author (@romanovvlad) to approve.

[MrSidims]

@romanovvlad could you please take a look?

[romanovvlad]

Good enough for me. It's not perfect, but I don't think it's worth improving it before we see the need for this. I'd like original author (@romanovvlad) to approve.

Agree, do not think it's common to use these keywords in regular comments. I'm OK with current solution.