Skip to content

[ESIMD] Add basic operations code generation test for half type. #5241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2022
Merged

[ESIMD] Add basic operations code generation test for half type. #5241

merged 2 commits into from
Jan 4, 2022

Conversation

kbobrovs
Copy link
Contributor

Signed-off-by: Konstantin S Bobrovsky [email protected]

@kbobrovs
Fix clang-format
dc6ab69 
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
@kbobrovs kbobrovs requested a review from a team as a code owner January 2, 2022 04:11
@kbobrovs
Copy link
Contributor Author

kbobrovs commented Jan 4, 2022

The pre-commit failure is unrelated to this change:

  • Reduction/reduction_nd_ext_double.cpp

@kbobrovs kbobrovs merged commit 8677d5d into intel:sycl Jan 4, 2022
@kbobrovs kbobrovs deleted the half_cg_test branch January 4, 2022 23:26
@bader
Copy link
Contributor

bader commented Jan 10, 2022

@kbobrovs, this change breaks post-commit check - https://github.com/intel/llvm/runs/4708566128?check_suite_focus=true.
Please, fix as soon as possible.

@pvchupin
Copy link
Contributor

Tagging @v-klochkov, as konst was out today.

@v-klochkov
Copy link
Contributor

Sure, I uploaded the fix for the test: #5278
The test passed when was build with default configuration, but failed with "configure --no-assertions".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

@kychendev kychendev Awaiting requested review from kychendev

@sndmitriev sndmitriev Awaiting requested review from sndmitriev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbobrovs @bader @pvchupin @v-klochkov