[Driver][SYCL] Enable ability to consume fat objects containing SPIR-V #5251
Conversation
When a user creates objects/archives based off of -fsycl-device-obj=spirv
we want to be able to consume these objects seamlessly. After any objects
are unbundled, we will pass these through spirv-to-ir-wrapper to potentially
convert them to LLVM-IR before performing the device link.
Toolchain flow will resemble:
fat object
|
unbundle
|
+-------+------+
| |
spirv-to-ir |
| |
llvm-link |
| |
wrap |
| |
+-------+------+
|
link
|
/summary:run |
There was a problem hiding this comment.
LGTM aside from a few minor comments.
As far as E2E testing is concerned, I believe that Precommit & Summary tests include sufficient uses of fat object usage to serve as regression checks. It would make sense to introduce explicit E2E tests for SPIR-V containing objects; however, with the level of unit testing for the current PR + spirv-to-ir-wrapper LITs, absence of E2E shouldn't be a severe blocker.
UPD: Obviously, a better moment for E2E test introduction would be once the generation of SPV-based objects is enabled. I've somehow forgotten that it's still ahead :D
|
Hoping folks are back from Holiday to take a look for merging. Is anybody from @intel/llvm-gatekeepers around? |
@pvchupin, @mdtoguchi, I think we should update the design document. The diagrams in https://github.com/intel/llvm/blob/sycl/sycl/doc/CompilerAndRuntimeDesign.md#dpc-compiler-architecture section seem outdated. |
|
More specifically: https://github.com/intel/llvm/blob/sycl/sycl/doc/CompilerAndRuntimeDesign.md#separate-compilation-and-linking should be augmented to reflect the ability to create fat objects with SPIR-V instead of LLVM-IR as well as consume. |
|
@mdtoguchi, can you follow up on this update please? |
When a user creates objects/archives based off of -fsycl-device-obj=spirv
we want to be able to consume these objects seamlessly. After any objects
are unbundled, we will pass these through spirv-to-ir-wrapper to potentially
convert them to LLVM-IR before performing the device link.
Toolchain flow will resemble:
fat object
|
unbundle
|
+-------+------+
| |
spirv-to-ir |
| |
llvm-link |
| |
wrap |
| |
+-------+------+
|
link