Skip to content

[SYCL][XPTI] Add missing buffer constructor data #5259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 31, 2022
Merged

[SYCL][XPTI] Add missing buffer constructor data #5259

merged 9 commits into from
Jan 31, 2022

Conversation

vladimirlaz
Copy link
Contributor

@vladimirlaz vladimirlaz commented Jan 4, 2022 •
edited
Loading

Extend information about created buffer:

  • Host object used to create buffer;
  • A string representing the type of buffer element;
  • Buffer element size in bytes
  • Buffer dimensions number.
  • Buffer size for each dimension.

The test changes in intel/llvm-test-suite#788 should be merged after this PR is merged.

@vladimirlaz vladimirlaz requested a review from a team as a code owner January 4, 2022 17:03
@vladimirlaz
Copy link
Contributor Author

/verify with intel/llvm-test-suite#703

@vladimirlaz
Copy link
Contributor Author

The failures are expected and the tests updated accordingly have passed: Jenkins/verify-test-suite-logs

alexbatashev
alexbatashev suggested changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already expose this info via edge_create tracepoint. Why is this duplication needed?

@vladimirlaz vladimirlaz mentioned this pull request Jan 31, 2022
Merged
@vladimirlaz vladimirlaz changed the title [SYCL][XPTI] Add kernel-accessor association [SYCL][XPTI] Add missing buffer constructor data Jan 31, 2022
alexbatashev
alexbatashev reviewed Jan 31, 2022
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladimirlaz please provide the description and make sure the title of this PR matches its content

@vladimirlaz vladimirlaz merged commit fc0d28a into intel:sycl Jan 31, 2022
@vladimirlaz vladimirlaz mentioned this pull request Jan 31, 2022
Merged
vladimirlaz added a commit that referenced this pull request Jan 31, 2022
@vladimirlaz
[SYCL] Fix CI failure (#5434)
c230f3c 
Fix build issues introduced by #5259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbatashev alexbatashev alexbatashev approved these changes

@v-klochkov v-klochkov Awaiting requested review from v-klochkov v-klochkov is a code owner automatically assigned from intel/llvm-reviewers-runtime

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladimirlaz @alexbatashev