[ESIMD] Enable some of intrinsic math ops on wrapper element types. #5271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable * inv, log, exp, sqrt, sqrt_ieee, rsqrt, sin, cos, pow, saturation on wrapper element types (sycl::half at the moment) - Fix host implementation to support wrapper types - TODO some intrinsics like rounding, inverse trigonometric functions are still not supported - will cause compile-time error Signed-off-by: Konstantin S Bobrovsky <[email protected]>
kbobrovs
force-pushed
the
half_ext_math
branch
from
5da2ac5 to
e36b3e0
Compare
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
v-klochkov
reviewed
Jan 8, 2022
sycl/include/sycl/ext/intel/experimental/esimd/detail/math_intrin.hpp
Outdated
Show resolved
Hide resolved
v-klochkov
reviewed
Jan 8, 2022
|
/verify with intel/llvm-test-suite#711 |
|
The precommit failure is a single test - ext_math.cpp. It is expected and is fixed by intel/llvm-test-suite#711 |
Co-authored-by: Vyacheslav Klochkov <[email protected]>
v-klochkov
previously approved these changes
Jan 11, 2022
kbobrovs
commented
Jan 12, 2022
|
@v-klochkov, I just fixed issue similar to #5278, please re-approve |
v-klochkov
approved these changes
Jan 12, 2022
|
/verify with intel/llvm-test-suite#711 |
|
re-run with intel/llvm-test-suite#711 shows single unrelated failure on Linux: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on wrapper element types (sycl::half at the moment)
are still not supported - will cause compile-time error
Complementary E2E test: intel/llvm-test-suite#711
Signed-off-by: Konstantin S Bobrovsky [email protected]