[Matrix][SYCL] Change the template parameter of joint_matrix_fill to … #5277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix the issue of deduced conflicting types This is because Type deduction does not consider implicit conversions (other than type adjustments listed above): that's the job for overload resolution, which happens later.
|
ping? @intel/llvm-reviewers-runtime |
vladimirlaz
approved these changes
Jan 11, 2022
|
@vladimirlaz could you help us merge it? |
We need to wait until tests finish. |
dm-vodopyanov
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jan 19, 2022
The bug causing the fill instruction to fail has been fixed: intel/llvm#5277
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…te#742) The bug causing the fill instruction to fail has been fixed: intel#5277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fix the issue of deduced conflicting types
This is because Type deduction does not consider implicit conversions
(other than type adjustments listed above): that's the job for overload
resolution, which happens later.
https://godbolt.org/z/W4z3KcbbY is a small reproducer for fill's bug and https://godbolt.org/z/d7nPKhnGh is a fix.