[SYCL][Test] Add negative checks for the variadic O0 printf LIT #5302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to intel#5286. Signed-off-by: Artem Gindinson <[email protected]>
|
I think dpcpp-esimd-reviewers is assigned due to mistake in the code owners file, which is being fixed. But I will give my approval to enable merge, hoping others will do actual review. |
kbobrovs
previously approved these changes
Jan 14, 2022
Thanks @kbobrovs - this truly is by code-ownership-related mistake, and #5287 should have resolved it now (thanks to your approval there, too!). |
mlychkov
reviewed
Jan 14, 2022
llvm/test/SYCLLowerIR/printf_addrspace/generic_as_negative_checks.ll
Outdated
Show resolved
Hide resolved
added 3 commits
January 14, 2022 12:06
Signed-off-by: Artem Gindinson <[email protected]>
Signed-off-by: Artem Gindinson <[email protected]>
AlexeySachkov
approved these changes
Jan 14, 2022
mlychkov
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #5286.
In addition, reflect the default PM switch in the existing
RUNlines.Signed-off-by: Artem Gindinson [email protected]