-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][NewPM] Disable vectorization and loop transformation #5305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NewPM] Disable vectorization and loop transformation #5305
Conversation
Port changes that disable vectorization and loop transformation passes in optimization pipeline from legacy Pass Manager builder to new PM builder (see commit ff6929e). Also for those tests that fail without this fix after optimization by the new Pass Manager add validation for both legacy and new PMs. Signed-off-by: Mikhail Lychkov <[email protected]>
Signed-off-by: Mikhail Lychkov <[email protected]>
The full set of fixes for new PM also validated in #4860. |
// RUN: %clangxx -I %sycl_include %s -o %t.out -fsycl -O0 -g | ||
// Check that the code compiles with -O0 and -g on both legacy and new Pass | ||
// Managers | ||
// RUN: %clangxx -I %sycl_include %s -o %t.out -fsycl -fno-legacy-pass-manager -O0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is added to esimd tests? How these 3 tests were selected for such modification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They crash on SYCLLowerESIMD pass execution step if loop transformation and vectorization passes are enabled in CodeGen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbobrovs Could you please provide feedback or approve the PR if there are no more concerns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. @mlychkov - could you please instead mark them as XFAIL, add a TODO and file an internal ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think I get it now. Thanks!
@mlychkov, could you please resolve merge conflicts? |
…_loop_passes_for_sycl
Precommit tests failed due to CI infrastructure issue. Corresponding issue was raised already. |
…_loop_passes_for_sycl
@intel/dpcpp-tools-reviewers, ping. |
The issue about failed pre-commit on Windows has been raised. |
Port changes that disable vectorization and loop transformation passes
in optimization pipeline from legacy Pass Manager builder to new PM builder
(see commit ff6929e).
Also for those tests that fail without this fix after optimization by
the new Pass Manager add validation for both legacy and new PMs.
Signed-off-by: Mikhail Lychkov [email protected]