[SYCL] Deprecate Intel extension ctz function #5333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redefinition of default constructor image_accessor() (previously used "= default") to make it possible to use const references in parallel_for.
Reduced ad hoc test file.
Fixed typo
Rewrite of RUN part.
Created new test for fixed issue with mismatched namespace for ctz function.
Rewritten call check.
Aborted changed constructor.
Changed commented line for testing purposes.
bader
reviewed
Jan 18, 2022
| long long int a = -9223372034707292160ll; | ||
| auto b = sycl::ctz(a); | ||
| return 0; | ||
| // CHECK: call spir_func i32 {{.*}}__sycl_std::__invoke_ctz{{.*}} i32 addrspace(1)* |
There was a problem hiding this comment.
Please, learn about FileCheck works. You must invoke the right executable to make sense of this comment.
Co-authored-by: Alexey Bader <[email protected]>
vladimirlaz
reviewed
Jan 19, 2022
Co-authored-by: vladimirlaz <[email protected]>
Added deprecation warning.
vladimirlaz
approved these changes
Jan 26, 2022
bader
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctz function is added to the core SYCL specification.
Added a test for fixed issue (changed namespace for ctz function).