[SYCL] Fix crash during search for undefined functions #5342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a crash if operator `new` was used inside recursive function or if undefined overloaded operator `new` was used inside random device code. The reason for crash is that `FunctionDecl` that represents operator `new` doesn't have a valid name in AST and `isSYCLUndefinedAllowed` checks it.
erichkeane
reviewed
Jan 19, 2022
elizabethandrews
approved these changes
Jan 20, 2022
smanna12
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a crash if operator
newwas used inside recursive functionor if undefined overloaded operator
newwas used inside random devicecode. The reason for crash is that
FunctionDeclthat representsoperator
newdoesn't have a valid name in AST andisSYCLUndefinedAllowedchecks it.