[SYCL] Remove outdated & invalid device score boost #5349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every device that satisfies filter options receives 1000 as starting score. Device that doesn't satisfy filter settings is filtered out on get_devices step.So no need to do extra boost for devices which DeviceNum is equal to the one specified in filter. Signed-off-by: Tikhomirova, Kseniya <[email protected]>
device::get_devices returns devices that satisfies SYCL_DEVICE_FILTER. extension filter_selector is also based on get_devices and just add extra level of device filtering. no way to get device that do not satisfy SYCL_DEVICE_FILTER in runtim so that operator() have to do filter check
KseniyaTikhomirova
requested review from
vladimirlaz,
romanovvlad and
s-kanaev
|
LGTM |
bader
changed the title
s-kanaev
reviewed
Jan 20, 2022
bso-intel
approved these changes
Jan 20, 2022
working on test rework right now |
|
uploaded PR for test intel/llvm-test-suite#775 |
|
/verify with intel/llvm-test-suite#786 |
|
/verify with intel/llvm-test-suite#775 |
|
Hi @vladimirlaz, this PR passed checks with the corresponding change in test suite. Could you please review and merge if no concerns? Thank you. |
|
Will be merged later today. |
vladimirlaz
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every device that satisfies filter options receives 1000 as starting score.
Device that doesn't satisfy filter settings is filtered out on get_devices step. So no need to do extra boost for devices which DeviceNum is equal to the one specified in filter.