[Driver][SYCL] Do device section checking only when offloading is enabled #5384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled Currently, device section checking is always called whether offloading is enabled or not. However, it is not needed when offloading is not enabledd. Signed-off-by: Qichao Gu <[email protected]>
qichaogu
changed the title
qichaogu
commented
Jan 25, 2022
mdtoguchi
reviewed
Jan 25, 2022
clang/lib/Driver/Driver.cpp
Outdated
| // in FPGA Hardware/Simulation mode. | ||
| if (!C.getDriver().isFPGAEmulationMode() && | ||
| hasFPGABinary(C, LA.str(), types::TY_FPGA_AOCO)) | ||
| if (Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false)) { |
There was a problem hiding this comment.
This can be moved up further to line 5882. Also, it may not be a bad idea to move this entire static lib unbundling to a separate function as part of OffloadingActionBuilder, cleaning up this area to be a bit more concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, device section checking is always called whether
offloading is enabled or not.
However, it is not needed when offloading is not enabled.
Signed-off-by: Qichao Gu [email protected]