[SYCL] Allow calls through constant expr function pointers #5390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current SYCL spec doesn't allow any indirect calls, but it may make sense to allow calls to constant expression function pointers because they are lowered to direct calls by front-end.
smanna12
reviewed
Jan 27, 2022
premanandrao
approved these changes
Jan 28, 2022
smanna12
approved these changes
Jan 28, 2022
elizabethandrews
approved these changes
Jan 28, 2022
|
Thanks for the reviews everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current SYCL spec doesn't allow any indirect calls, but it makes sense
to allow indirect calls when called function pointer is a constant expression
because such calls are lowered to direct calls by the front-end.