[SYCL] Use correct scalar types for vector elements on Windows [revised] #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
previously approved these changes
Aug 23, 2019
sndmitriev
force-pushed
the
public/sndmitriev/long-long-types-new
branch
2 times, most recently
from
3ac98bd to
6b30e73
Compare
v-klochkov
previously approved these changes
Aug 27, 2019
|
Looks like the LIT test fail (vector_math.cpp) on buildbot/sycl-ubu-x64-pr has nothing to do with this patch. Is it expected to fail now? |
Yes, now this test disabled. Please rebase your patch. |
Implementation uses wrong types for 64-bit integers on Windows for vector elements because '[unsigned] long' is being used. But on Windows 'long' has 32 bits as opposed to 64 bits on Linux. This patch corrects this problem. This is a revised fix for the earlier commit e933485. Previous change is reverted. Signed-off-by: Sergey Dmitriev <[email protected]>
sndmitriev
force-pushed
the
public/sndmitriev/long-long-types-new
branch
from
6b30e73 to
c2f37cc
Compare
v-klochkov
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation uses wrong types for 64-bit integers on Windows for vector
elements because '[unsigned] long' is being used. But on Windows 'long'
has 32 bits as opposed to 64 bits on Linux. This patch corrects this
problem.
This is a revised fix for the earlier commit e933485. Previous change
is reverted.
Signed-off-by: Sergey Dmitriev [email protected]