[SYCL] Add unit test for PR 5414 #5450
Conversation
This patch adds unit test for intel#5414. This test creates ExecCGCommand with some known values needed in RT to restore context in host task. After that we start enqueueing and verify the correctness of these values in mocked piEnqueueNativeKernel func.
| @@ -17,5 +17,6 @@ add_sycl_unittest(SchedulerTests OBJECT | |||
| RequiredWGSize.cpp | |||
| QueueFlushing.cpp | |||
| PostEnqueueCleanup.cpp | |||
| Regression.cpp | |||
There was a problem hiding this comment.
Suggest renaming to some descriptive name.
There was a problem hiding this comment.
I think it will be good to have the separate file for all scheduler regressions similar to the folder https://github.com/intel/llvm/tree/sycl/sycl/test/regression
Does it make sense? In this case the file has name Regression.cpp.
Do you have other ideas regarding the name?
There was a problem hiding this comment.
the change/fix was to ensure the context was restored when cleaning up when using run-on-host-intel correct? So maybe instead of "regression.cpp" we should call it "RunOnHostIntelCleanupCorrect.cpp" or similar.
|
Working on resolving the failure. Unit test can't be run on host device, it works only when OpenCL or other backend is present. Will try to mock something. |
* upstream/sycl: (3571 commits) [ESIMD] Doxygen update part III - core APIs. (intel#5472) [SYCL][DOC] Move proposed FPGA extensions (intel#5453) [SYCL] Add -fsycl-fp32-prec-sqrt flag (intel#5309) [SYCL] Emit program build logs for warning levels >= 2 (intel#5319) [SYCL] Add clang support for code_location in KernelInfo (intel#5335) [SYCL][Doc] Move FPGA extensions (intel#5470) [ESIMD] Fix public simd and simd_view APIs. (intel#5465) [SYCL] Deprecate sycl::atomics in SYCL 2020 mode (intel#5440) [SYCL] Add unit test for PR 5414 (intel#5450) [XPTI] Allow arbitrary data types in metadata (intel#4998) [SYCL][DOC] Move discard queue events to supported (intel#5452) [Driver][SYCL] Initial support for allowing fat static -lname processing (intel#5413) [SYCL] Fix dead pointer usage if leaf buffer overflows (intel#5417) [SYCL][L0] Fix memory leak in USM prefetch (intel#5461) [SYCL][Doc] Add new free function queries proposal (intel#5106) [SYCL][ESIMD] Update vc-intrinsics deps to the top of the trunk (intel#5460) [SYCL][DOC] Move old spec constant extension spec (intel#5456) [SYCL][DOC] Move deprecated extensions (intel#5458) [SYCL][DOC] Fix links to old SubGroupMask doc (intel#5459) [ESIMD] Doxygen update part II - memory APIs. (intel#5443) ...
This patch adds unit test for #5414.
This test creates ExecCGCommand with some known values needed in RT to
restore context in host task. After that we start enqueueing and verify
the correctness of these values in mocked piEnqueueNativeKernel func.