Skip to content

[SYCL] Pass driver options to JIT compiler and linker #5476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Feb 28, 2022
Merged

[SYCL] Pass driver options to JIT compiler and linker #5476

merged 44 commits into from
Feb 28, 2022

Conversation

HabKaffee
Copy link
Contributor

This patch implements passing compiler and link options to sycl::compile() and sycl::link() respectively.

@HabKaffee HabKaffee requested a review from a team as a code owner February 4, 2022 15:05
cperkinsintel
cperkinsintel reviewed Feb 4, 2022
View reviewed changes
cperkinsintel
cperkinsintel previously approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HabKaffee HabKaffee mentioned this pull request Feb 7, 2022
Merged
@HabKaffee
Copy link
Contributor Author

I found, that this patch is affecting 1 more test in intel/llvm-test-suite. Working on it.

@HabKaffee HabKaffee marked this pull request as draft February 7, 2022 08:25
@HabKaffee
Copy link
Contributor Author

/verify with intel/llvm-test-suite#806

@HabKaffee
Copy link
Contributor Author

/verify with intel/llvm-test-suite#806

@HabKaffee
Copy link
Contributor Author

/verify with intel/llvm-test-suite#806

steffenlarsen
steffenlarsen previously approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor nit, otherwise LGTM!

@HabKaffee HabKaffee dismissed stale reviews from steffenlarsen and romanovvlad via c70286a February 16, 2022 22:55
@HabKaffee
Copy link
Contributor Author

@steffenlarsen @romanovvlad Could you, please, reapprove this PR?

steffenlarsen
steffenlarsen previously approved these changes Feb 16, 2022
View reviewed changes
@HabKaffee
Copy link
Contributor Author

/verify with intel/llvm-test-suite#806

@HabKaffee
Copy link
Contributor Author

I have resolved merge conflict between my branch and intel/sycl. @steffenlarsen @romanovvlad could you, please, reapprove this PR?

@HabKaffee
Copy link
Contributor Author

/verify with intel/llvm-test-suite#806

@HabKaffee
Copy link
Contributor Author

/verify with intel/llvm-test-suite#806

@bader bader changed the title [SYCL] Implementation of passing compiler and link options to compiler and linker [SYCL] Pass driver options to JIT compiler and linker Feb 22, 2022
@HabKaffee
Copy link
Contributor Author

All check, which are failing, were fixed by intel/llvm-test-suite#806 .

@bader
Copy link
Contributor

bader commented Feb 28, 2022

@vladimirlaz, could you merge this PR, please?

@vladimirlaz
Copy link
Contributor

@vladimirlaz, could you merge this PR, please?

will do after 6PM MSK

@vladimirlaz vladimirlaz merged commit 1c93bfe into intel:sycl Feb 28, 2022
@vladimirlaz
Copy link
Contributor

@HabKaffee it looks like we have post-commit build failure with the patch

@bader
Copy link
Contributor

bader commented Feb 28, 2022

Is it caused by this patch or 87f60f6?

@HabKaffee
Copy link
Contributor Author

@vladimirlaz I see, that 87f60f6 which was before my commit failed

@vladimirlaz
Copy link
Contributor

Sorry, you are right...

@romanovvlad romanovvlad mentioned this pull request Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirlaz vladimirlaz vladimirlaz approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@alexbatashev alexbatashev Awaiting requested review from alexbatashev

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel

@romanovvlad romanovvlad Awaiting requested review from romanovvlad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HabKaffee @romanovvlad @bader @vladimirlaz @alexbatashev @cperkinsintel @steffenlarsen