[SYCL] Change cast for vector<cl_event> if SYCL2020_CONFORMANT_APIS macro is defined #5498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirlaz
suggested changes
Feb 16, 2022
vladimirlaz
reviewed
Feb 16, 2022
vladimirlaz
requested review from
vladimirlaz,
s-kanaev and
alexbatashev
and removed request for
vladimirlaz
alexbatashev
approved these changes
Feb 21, 2022
s-kanaev
approved these changes
Feb 22, 2022
vladimirlaz
approved these changes
Feb 24, 2022
|
@intel/llvm-reviewers-runtime, can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change cast for vector<cl_event> if SYCL2020_CONFORMANT_APIS macro is defined.
According to the spec, make_event<sycl::backend::opencl>() should create one cl_event from a vector of cl_event