[Matrix][SYCL] Refactor matrix feature header file #5532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yubingex007-a11y
changed the title
Comment on lines
340
to
349
| OP(T, +) | ||
| OP(T, -) | ||
| OP(T, *) | ||
| OP(T, /) | ||
| OP(bool, ==) | ||
| OP(bool, !=) | ||
| OP(bool, <) | ||
| OP(bool, >) | ||
| OP(bool, <=) | ||
| OP(bool, >=) |
There was a problem hiding this comment.
should we delete all the overloaded operator's function since implicit conversion from wi_element to T is provided?
Of course we should keep overloaded operator's function of the bfloat16.
…mplicit conversion from wi_element<T> to T
yubingex007-a11y
requested review from
LuoYuanke and
dkhaldi
and removed request for
dkhaldi
|
ping? |
AlexeySotkin
previously approved these changes
Feb 17, 2022
|
@steffenlarsen @dkhaldi any comments? |
| static uint16_t convert(const T &from) { return make_bf16(from); } | ||
| }; | ||
| #if __SYCL_DEVICE_ONLY__ | ||
| #define OP(input_type, type, op) \ |
There was a problem hiding this comment.
Eh, I am not gifted at naming, do we have a better naming style for 'inuput_type' here? actually it represents input type of 'convert' function.
yubingex007-a11y
requested review from
steffenlarsen,
AlexeySotkin and
v-klochkov
steffenlarsen
previously approved these changes
Feb 24, 2022
steffenlarsen
approved these changes
Feb 25, 2022
|
@bader @vladimirlaz could you please help us merge it? |
bader
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow operands of different type in some overloaded function in wi_element.