[SYCL] Make default device the one selected by default_selector #5587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
|
/verify with intel/llvm-test-suite#845 |
bader
requested changes
Feb 16, 2022
Comment on lines
40
to
+41
| /// Constructs a SYCL device instance as a host device. | ||
| device(host_device); |
There was a problem hiding this comment.
I don't see this constructor in the specification. Why do you think we should add it?
There was a problem hiding this comment.
I don't think there's an approval to remove host device completely. Also, libsycl.so makes use of host device.
There was a problem hiding this comment.
I'm not suggesting we move the host device support completely, but we should not add silently add non-standard functionality w/o extending the specification.
You can use aspect_selector with host aspect to select a host device. The host aspect is not in the standard, but it's already supported by DPC++, so no new extensions are needed.
Signed-off-by: Sergey Kanaev <[email protected]>
|
/verify with intel/llvm-test-suite#845 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host device still can be retrieved with help of special tag
host_device: