CMakelist improvements: add deploy target, Install OpenCL headers, some minor cleanup. #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
previously approved these changes
Aug 28, 2019
There was a problem hiding this comment.
Looks good to me.
Also, I tried your fix on Windows. It fixed some old issues with dependencies, for example, from OpenCL.dll to sycl.dll.
Before your fix 'ninja' could not be used without specifying path to existing OpenCL.lib in -DOpenCL_LIBRARY= argument.
Now it works perfect.
bader
reviewed
Aug 30, 2019
sycl/CMakeLists.txt
Outdated
| message( STATUS "Adding component ${comp} to deploy") | ||
|
|
||
| set (manifest_file ${CMAKE_CURRENT_BINARY_DIR}/install_manifest_${comp}.txt) | ||
| add_custom_command(OUTPUT ${manifest_file} |
There was a problem hiding this comment.
Valery is on vacation. I fixed this indentation issue and re-based the patch
to get passes on those 2 failed LIT tests on Windows (boolean.cpp and vector_extracts.cpp) and to check that the nothing got broken while this patch was in review.
No semantics changes done be me.
Implemented deploy target. Minor build scripts cleanup. Signed-off-by: Valery N Dmitriev <[email protected]>
v-klochkov
force-pushed
the
cmake_improvements
branch
from
f1972ca to
371dd85
Compare
v-klochkov
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added OpenCL headers to "install".
Implemented deploy target.
Minor build scripts cleanup.
Signed-off-by: Valery N Dmitriev [email protected]